fix(build): make react-ui and browser-bundle build scripts cross-plat…#604
Merged
abhithesys merged 3 commits intoJun 9, 2026
Conversation
abhithesys
reviewed
Jun 8, 2026
abhithesys
left a comment
abhithesys
left a comment
Contributor
There was a problem hiding this comment.
Changes look good. Can you update the PR to use rimraf pkg instead?
Its a well known pkg to solve this particular issue, we shouldn't need to write this script in every pkg that exists in Openui.
Contributor
Author
|
Updated the PR to use rimraf and removed the custom cleanup scripts. Re-tested on Windows and the original build-script issue is resolved. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Fixes #603 by replacing Unix-specific build commands with cross-platform Node.js helper scripts in
@openuidev/react-uiand@openuidev/browser-bundle.On Windows, builds fail with:
Changes
Replaced
rm -rfandmkdir -pusage with Node.js filesystem APIs while preserving the existing build behavior.Test Plan
Validated on Windows 11 using PowerShell.
@openuidev/react-uinow builds successfully.@openuidev/browser-bundleprogresses past the shell-command failure and reaches the bundling stage. Validation exposed a separate module resolution issue:These errors appear unrelated to the Windows compatibility issue addressed in this PR.
Checklist